Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1152453009: pkg/scheduled_test: fix analyzer hints (Closed)

Created:
5 years, 6 months ago by kevmoo
Modified:
5 years, 6 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/scheduled_test.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more better? #

Total comments: 6

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -26 lines) Patch
M lib/scheduled_process.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/scheduled_server.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/descriptor/directory_descriptor.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/descriptor/file_descriptor.dart View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M lib/src/descriptor/nothing_descriptor.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pubspec.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/descriptor/async_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/descriptor/directory_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/descriptor/file_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/descriptor/nothing_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/descriptor/pattern_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/scheduled_server_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M test/scheduled_stream/stream_matcher_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/scheduled_test/current_schedule_current_task_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/scheduled_test/current_schedule_errors_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M test/scheduled_test/nested_task_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/scheduled_test/out_of_band_task_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/scheduled_test/unhandled_error_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/utils.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
kevmoo
5 years, 6 months ago (2015-06-04 19:14:22 UTC) #2
nweiz
https://codereview.chromium.org/1152453009/diff/20001/lib/src/descriptor/file_descriptor.dart File lib/src/descriptor/file_descriptor.dart (right): https://codereview.chromium.org/1152453009/diff/20001/lib/src/descriptor/file_descriptor.dart#newcode84 lib/src/descriptor/file_descriptor.dart:84: Future _validateNow(List<int> actualContents) async { Don't use async/await in ...
5 years, 6 months ago (2015-06-04 19:20:11 UTC) #3
kevmoo
https://codereview.chromium.org/1152453009/diff/20001/lib/src/descriptor/file_descriptor.dart File lib/src/descriptor/file_descriptor.dart (right): https://codereview.chromium.org/1152453009/diff/20001/lib/src/descriptor/file_descriptor.dart#newcode84 lib/src/descriptor/file_descriptor.dart:84: Future _validateNow(List<int> actualContents) async { On 2015/06/04 19:20:10, nweiz ...
5 years, 6 months ago (2015-06-04 19:23:46 UTC) #4
nweiz
lgtm
5 years, 6 months ago (2015-06-04 19:31:39 UTC) #5
kevmoo
5 years, 6 months ago (2015-06-04 20:05:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
9421d9d7089397dd74f42af351172fe12b385320 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698