pkg/scheduled_test: fix analyzer hints

lib/src/descriptor/file_descriptor.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library descriptor.file;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 import 'dart:math' as math;
 
 import 'package:path/path.dart' as path;
-import 'package:stack_trace/stack_trace.dart';
 
 import '../../descriptor.dart';
 import '../../scheduled_test.dart';
 import '../utils.dart';
 
 /// A descriptor describing a single file.
 abstract class FileDescriptor extends Descriptor implements ReadableDescriptor {
   /// The contents of the file, in bytes.
   final List<int> contents;
 
@@ skipping 51 matching lines @@
 
   Stream<List<int>> read() => new Future.value(contents).asStream();
 
   String describe() => name;
 }
 
 class _BinaryFileDescriptor extends FileDescriptor {
   _BinaryFileDescriptor(String name, List<int> contents)
       : super._(name, contents);
 
-  Future _validateNow(List<int> actualContents) {
+  Future _validateNow(List<int> actualContents) async {

[nweiz, 2015/06/04 19:20:10]

Don't use async/await in scheduled test until issue 23497 is fixed.

[kevmoo, 2015/06/04 19:23:46]

Done.

     if (orderedIterableEquals(contents, actualContents)) return null;
     // TODO(nweiz): show a hex dump here if the data is small enough.
-    fail("File '$name' didn't contain the expected binary data.");
+    throw new TestFailure(
+        "File '$name' didn't contain the expected binary data.");

[nweiz, 2015/06/04 19:20:10]

Why aren't you calling fail() here anymore?

[kevmoo, 2015/06/04 19:23:46]

analyzer yells about having one flow w/ a return value and one without – throw
makes it happy

   }
 }
 
 class _StringFileDescriptor extends FileDescriptor {
   _StringFileDescriptor(String name, String contents)
       : super._(name, UTF8.encode(contents));
 
   Future _validateNow(List<int> actualContents) {
     if (orderedIterableEquals(contents, actualContents)) return null;
-    throw _textMismatchMessage(textContents,
-        new String.fromCharCodes(actualContents));
+    throw new TestFailure(_textMismatchMessage(
+        textContents, new String.fromCharCodes(actualContents)));
   }
 
   String _textMismatchMessage(String expected, String actual) {
     final expectedLines = expected.split('\n');
     final actualLines = actual.split('\n');
 
     var results = [];
 
     // Compare them line by line to see which ones match.
     var length = math.max(expectedLines.length, actualLines.length);
@@ skipping 31 matching lines @@
 
   _MatcherFileDescriptor(String name, this._matcher, {bool isBinary})
       : _isBinary = isBinary == true ? true : false,
         super._(name, <int>[]);
 
   void _validateNow(List<int> actualContents) =>
       expect(
           _isBinary ? actualContents : new String.fromCharCodes(actualContents),
           _matcher);
 }