Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1152283005: Revert "Add the streamListen and streamCancel rpcs to the vm service." (Closed)

Created:
5 years, 7 months ago by turnidge
Modified:
5 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add the streamListen and streamCancel rpcs to the vm service." This reverts commit 0967b6307399b9296faa58b9b56eca045c9112d9. Conflicts: runtime/observatory/tests/service/graph_test.dart runtime/vm/service.cc BUG= Committed: https://github.com/dart-lang/sdk/commit/8d2437233923953f4604dde3880437f93dbfdcdb

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -477 lines) Patch
M runtime/bin/main.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/server.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/include/dart_api.h View 1 chunk +13 lines, -14 lines 0 comments Download
M runtime/observatory/lib/service_common.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 4 chunks +5 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_profile.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 3 chunks +8 lines, -53 lines 0 comments Download
M runtime/observatory/tests/service/async_generator_breakpoint_test.dart View 3 chunks +18 lines, -23 lines 0 comments Download
M runtime/observatory/tests/service/code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/coverage_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/debugger_inspect_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/debugging_test.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M runtime/observatory/tests/service/echo_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/eval_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/evaluate_activation_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/gc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/isolate_lifecycle_test.dart View 3 chunks +3 lines, -6 lines 0 comments Download
M runtime/observatory/tests/service/source_location_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/steal_breakpoint_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M runtime/vm/debugger.cc View 4 chunks +5 lines, -29 lines 0 comments Download
M runtime/vm/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +10 lines, -14 lines 0 comments Download
M runtime/vm/json_stream.h View 1 chunk +4 lines, -9 lines 0 comments Download
M runtime/vm/service.h View 2 chunks +5 lines, -21 lines 0 comments Download
M runtime/vm/service.cc View 11 chunks +22 lines, -82 lines 0 comments Download
M runtime/vm/service/client.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/service/message.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/vm/service/vmservice.dart View 9 chunks +26 lines, -117 lines 0 comments Download
M runtime/vm/service_event.h View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/service_event.cc View 2 chunks +0 lines, -31 lines 0 comments Download
M runtime/vm/service_isolate.cc View 2 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
TBR=rmacnak
5 years, 7 months ago (2015-05-26 22:10:00 UTC) #2
turnidge
Committed patchset #2 (id:20001) manually as 8d2437233923953f4604dde3880437f93dbfdcdb (presubmit successful).
5 years, 7 months ago (2015-05-26 22:22:44 UTC) #3
rmacnak
5 years, 7 months ago (2015-05-26 22:40:24 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698