Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: runtime/observatory/lib/src/elements/debugger.dart

Issue 1152283005: Revert "Add the streamListen and streamCancel rpcs to the vm service." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/app/page.dart ('k') | runtime/observatory/lib/src/elements/heap_profile.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/debugger.dart
diff --git a/runtime/observatory/lib/src/elements/debugger.dart b/runtime/observatory/lib/src/elements/debugger.dart
index aa5264335613f6056c4c18e13b35a288de24121d..c9be5ec4d9616e95379a383de2722b916766f38e 100644
--- a/runtime/observatory/lib/src/elements/debugger.dart
+++ b/runtime/observatory/lib/src/elements/debugger.dart
@@ -7,6 +7,7 @@ library debugger_page_element;
import 'dart:async';
import 'dart:html';
import 'observatory_element.dart';
+import 'package:observatory/app.dart';
import 'package:observatory/cli.dart';
import 'package:observatory/debugger.dart';
import 'package:observatory/service.dart';
@@ -878,11 +879,8 @@ class ObservatoryDebugger extends Debugger {
}
}
Future.wait(pending).then((_) {
- if (_isolateSubscription == null) {
- _isolateSubscription = vm.isolateEvents.listen(_onEvent);
- }
- if (_debugSubscription == null) {
- _debugSubscription = vm.debugEvents.listen(_onEvent);
+ if (_subscription == null) {
+ _subscription = vm.events.stream.listen(_onEvent);
}
_refreshStack(isolate.pauseEvent).then((_) {
reportStatus();
@@ -908,8 +906,7 @@ class ObservatoryDebugger extends Debugger {
}
Isolate get isolate => _isolate;
Isolate _isolate;
- var _isolateSubscription;
- var _debugSubscription;
+ var _subscription;
void init() {
console.newline();
@@ -1176,6 +1173,7 @@ class ObservatoryDebugger extends Debugger {
@CustomTag('debugger-page')
class DebuggerPageElement extends ObservatoryElement {
+ @published ObservatoryApplication app;
@published Isolate isolate;
isolateChanged(oldValue) {
« no previous file with comments | « runtime/observatory/lib/src/app/page.dart ('k') | runtime/observatory/lib/src/elements/heap_profile.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698