Issue 1152063004: Use artificial hashCode values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1152063004: Use artificial hashCode values. (Closed)

Created:
5 years, 7 months ago by scheglov

Modified:
5 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Use artificial hashCode values. This slightly improves invalidation performance, 40 ms vs. 60 ms. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b92708a9617449f3621710d4245484fef7888743

Patch Set 1 #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -3 lines)			Patch
M	pkg/analyzer/lib/src/generated/constant.dart	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/utilities_general.dart	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	pkg/analyzer/lib/src/task/model.dart	View	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1152063004/diff/1/pkg/analyzer/lib/src/generated/utilities_general.dart File pkg/analyzer/lib/src/generated/utilities_general.dart (right): https://codereview.chromium.org/1152063004/diff/1/pkg/analyzer/lib/src/generated/utilities_general.dart#newcode31 pkg/analyzer/lib/src/generated/utilities_general.dart:31: static int hash3(a, b, c) => finish(combine(combine(combine(0, a), ...

5 years, 7 months ago (2015-05-23 15:58:50 UTC) #2

scheglov

5 years, 7 months ago (2015-05-23 16:15:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b92708a9617449f3621710d4245484fef7888743 (presubmit successful).

Expand Messages | Collapse Messages