Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: pkg/analyzer/lib/src/generated/constant.dart

Issue 1152063004: Use artificial hashCode values. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/constant.dart
diff --git a/pkg/analyzer/lib/src/generated/constant.dart b/pkg/analyzer/lib/src/generated/constant.dart
index 379b4ad972a351b43a8f4daf3e3a6cf6f16d93a2..fa5360b8d87769eb4ed2ff81607308a243b8ea56 100644
--- a/pkg/analyzer/lib/src/generated/constant.dart
+++ b/pkg/analyzer/lib/src/generated/constant.dart
@@ -370,7 +370,8 @@ class ConstantEvaluationEngine {
VariableElementImpl variableElement =
element.variable as VariableElementImpl;
elementAnnotation.evaluationResult = variableElement.evaluationResult;
- } else if (element is ConstructorElementImpl && element.isConst &&
+ } else if (element is ConstructorElementImpl &&
+ element.isConst &&
constNode.arguments != null) {
RecordingErrorListener errorListener = new RecordingErrorListener();
CompilationUnit sourceCompilationUnit =
@@ -940,8 +941,8 @@ class ConstantEvaluationTarget_Annotation implements ConstantEvaluationTarget {
this.context, this.source, this.librarySource, this.annotation);
@override
- int get hashCode => JenkinsSmiHash.hash4(context.hashCode, source.hashCode,
- librarySource.hashCode, annotation.hashCode);
+ int get hashCode => JenkinsSmiHash.hash3(
+ source.hashCode, librarySource.hashCode, annotation.hashCode);
@override
bool operator ==(other) {

Powered by Google App Engine
This is Rietveld 408576698