Move bootstrap scripts and token streams to the VM isolate so that they become read only objects. T…

Move bootstrap scripts and token streams to the VM isolate so that they become read only objects. This reduces the per isolate heap size as follows:

Before the change:
Size of isolate snapshot = 780799
New space (0k of 1024k) Old space (758k of 1024k)

After the change:
Size of isolate snapshot = 279696
New space (0k of 1024k) Old space (602k of 1024k)

BUG=
R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/5e0a3d66e54807a10c703634f9b5224a4c8f1ef4

[siva, 2015-05-21 19:56:28]

asiva@google.com changed reviewers:
+ hausner@google.com

[hausner, 2015-05-21 20:37:13]

LGTM w/comment

https://codereview.chromium.org/1151113002/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1151113002/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:610: cls =
Class::NewExternalTypedDataClass(kExternalTypedDataUint8ArrayCid);
You don't use the value of cls anywhere. Is this line superfluous?

https://codereview.chromium.org/1151113002/diff/20001/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/1151113002/diff/20001/runtime/vm/snapshot.cc#...
runtime/vm/snapshot.cc:1476: // An object visitor which will serialize all .
This is used to
missing word after "serialize all"?
Lower case S in line below.

[siva, 2015-05-22 18:09:27]

https://codereview.chromium.org/1151113002/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1151113002/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:610: cls =
Class::NewExternalTypedDataClass(kExternalTypedDataUint8ArrayCid);
On 2015/05/21 20:37:12, hausner wrote:
> You don't use the value of cls anywhere. Is this line superfluous?

The class kExternalTypedDataUint8ArrayCid needs to be registered in the class
table so that it is available when a token stream is read and hence we set that
up here by calling Class::NewExternalTypedDataClass.
I added a comment above to make this clear.

https://codereview.chromium.org/1151113002/diff/20001/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/1151113002/diff/20001/runtime/vm/snapshot.cc#...
runtime/vm/snapshot.cc:1476: // An object visitor which will serialize all .
This is used to
On 2015/05/21 20:37:13, hausner wrote:
> missing word after "serialize all"?
> Lower case S in line below.

Done.

[siva, 2015-05-22 19:48:17]

Committed patchset #3 (id:40001) manually as
5e0a3d66e54807a10c703634f9b5224a4c8f1ef4 (presubmit successful).