Move bootstrap scripts and token streams to the VM isolate so that they become read only objects. T…

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 583 matching lines @@
   cls.set_num_own_type_arguments(1);
   cls = Class::New<Array>(kImmutableArrayCid);
   isolate->object_store()->set_immutable_array_class(cls);
   cls.set_type_arguments_field_offset(Array::type_arguments_offset());
   cls.set_num_type_arguments(1);
   cls.set_num_own_type_arguments(1);
   cls = Class::NewStringClass(kOneByteStringCid);
   isolate->object_store()->set_one_byte_string_class(cls);
   cls = Class::NewStringClass(kTwoByteStringCid);
   isolate->object_store()->set_two_byte_string_class(cls);
+  cls = Class::New<Mint>();
+  isolate->object_store()->set_mint_class(cls);
+  cls = Class::New<Bigint>();
+  isolate->object_store()->set_bigint_class(cls);
+  cls = Class::New<Double>();
+  isolate->object_store()->set_double_class(cls);
+  cls = Class::NewExternalTypedDataClass(kExternalTypedDataUint8ArrayCid);

[hausner, 2015/05/21 20:37:12]

You don't use the value of cls anywhere. Is this line superfluous?

[siva, 2015/05/22 18:09:27]

The class kExternalTypedDataUint8ArrayCid needs to be registered in the class
table so that it is available when a token stream is read and hence we set that
up here by calling Class::NewExternalTypedDataClass.
I added a comment above to make this clear.

 
   // Allocate and initialize the empty_array instance.
   {
     uword address = heap->Allocate(Array::InstanceSize(0), Heap::kOld);
     InitializeObject(address, kArrayCid, Array::InstanceSize(0));
     Array::initializeHandle(
         empty_array_,
         reinterpret_cast<RawArray*>(address + kHeapObjectTag));
     empty_array_->StoreSmi(&empty_array_->raw_ptr()->length_, Smi::New(0));
   }
@@ skipping 20116 matching lines @@
   return tag_label.ToCString();
 }
 
 
 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
   Instance::PrintJSONImpl(stream, ref);
 }
 
 
 }  // namespace dart