Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1150303004: Switch to using SourceLocation universally in service protocol. (Closed)

Created:
5 years, 6 months ago by turnidge
Modified:
5 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch to using SourceLocation universally in service protocol. Add <location-link> and <location-inset> to provide links and insets for a location. Make Frame, Message, and SourceLocation first class in service lib. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/6c2ebfcc60022c50a022c55c0dbfebee164f7be9

Patch Set 1 #

Patch Set 2 : Fix tests, cleanups #

Patch Set 3 : Renaming #

Patch Set 4 : fjdskl jafjdk jaja fdfjkal fjdfk ajdfkfj #

Patch Set 5 : post merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+458 lines, -971 lines) Patch
M runtime/observatory/lib/debugger.dart View 1 chunk +1 line, -1 line 0 comments Download
A + runtime/observatory/lib/src/debugger/debugger_location.dart View 7 chunks +26 lines, -26 lines 0 comments Download
D runtime/observatory/lib/src/debugger/source_location.dart View 1 chunk +0 lines, -366 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_view.html View 1 2 3 4 2 chunks +3 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 19 chunks +33 lines, -37 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.html View 1 2 4 chunks +18 lines, -25 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/function_view.html View 1 2 2 chunks +2 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_summary.html View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.html View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/observatory_element.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.dart View 1 2 7 chunks +32 lines, -11 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.html View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_ref.dart View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_ref.html View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 4 23 chunks +126 lines, -50 lines 0 comments Download
M runtime/observatory/tests/service/code_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/coverage_test.dart View 1 2 chunks +7 lines, -6 lines 0 comments Download
A + runtime/observatory/tests/service/debugger_location_test.dart View 1 20 chunks +45 lines, -45 lines 0 comments Download
M runtime/observatory/tests/service/debugging_test.dart View 1 5 chunks +10 lines, -10 lines 0 comments Download
M runtime/observatory/tests/service/eval_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/get_object_rpc_test.dart View 1 2 3 4 3 chunks +3 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/get_stack_rpc_test.dart View 1 3 chunks +12 lines, -15 lines 0 comments Download
D runtime/observatory/tests/service/source_location_test.dart View 1 chunk +0 lines, -281 lines 0 comments Download
M runtime/observatory/tests/service/steal_breakpoint_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger.cc View 1 2 3 3 chunks +13 lines, -10 lines 0 comments Download
M runtime/vm/debugger_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/json_stream.h View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M runtime/vm/message.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 chunks +5 lines, -8 lines 0 comments Download
M runtime/vm/service/service.md View 1 2 3 4 8 chunks +30 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 6 months ago (2015-06-02 22:57:17 UTC) #2
Cutch
lgtm
5 years, 6 months ago (2015-06-02 23:06:21 UTC) #3
turnidge
5 years, 6 months ago (2015-06-03 16:02:47 UTC) #4
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
6c2ebfcc60022c50a022c55c0dbfebee164f7be9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698