Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: runtime/observatory/tests/service/coverage_test.dart

Issue 1150303004: Switch to using SourceLocation universally in service protocol. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: post merge Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/coverage_test.dart
diff --git a/runtime/observatory/tests/service/coverage_test.dart b/runtime/observatory/tests/service/coverage_test.dart
index 1f75644e68901dd32f7d05c874a7d73a10cacb50..45a60a8a9ac669ce80c9a6a290adabf91c00cc91 100644
--- a/runtime/observatory/tests/service/coverage_test.dart
+++ b/runtime/observatory/tests/service/coverage_test.dart
@@ -83,13 +83,13 @@ var tests = [
// Make sure we are in the right place.
expect(stack.type, equals('Stack'));
expect(stack['frames'].length, greaterThanOrEqualTo(2));
- expect(stack['frames'][0]['function'].name, equals('myFunction'));
- expect(stack['frames'][0]['function'].dartOwner.name, equals('MyClass'));
+ expect(stack['frames'][0].function.name, equals('myFunction'));
+ expect(stack['frames'][0].function.dartOwner.name, equals('MyClass'));
var lib = isolate.rootLibrary;
- var func = stack['frames'][0]['function'];
+ var func = stack['frames'][0].function;
expect(func.name, equals('myFunction'));
- var cls = stack['frames'][0]['function'].dartOwner;
+ var cls = func.dartOwner;
expect(cls.name, equals('MyClass'));
List tests = [];
@@ -126,8 +126,9 @@ var tests = [
}));
// Script
tests.add(cls.load().then((_) {
- return isolate.invokeRpcNoUpgrade('_getCoverage',
- { 'targetId': cls.script.id })
+ return isolate.invokeRpcNoUpgrade(
+ '_getCoverage',
+ { 'targetId': cls.location.script.id })
.then((Map coverage) {
expect(coverage['type'], equals('CodeCoverage'));
expect(coverage['coverage'].length, equals(3));
« no previous file with comments | « runtime/observatory/tests/service/code_test.dart ('k') | runtime/observatory/tests/service/debugger_location_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698