Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1149973004: Start to compute SendStructure in resolution. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -13 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 5 chunks +30 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 2 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 7 months ago (2015-05-21 16:18:02 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1149973004/diff/1/pkg/compiler/lib/src/resolution/send_resolver.dart File pkg/compiler/lib/src/resolution/send_resolver.dart (right): https://codereview.chromium.org/1149973004/diff/1/pkg/compiler/lib/src/resolution/send_resolver.dart#newcode205 pkg/compiler/lib/src/resolution/send_resolver.dart:205: assert(invariant(node, false, message: "Unexpected assert.")); Shouldn't we always ...
5 years, 7 months ago (2015-05-22 10:08:36 UTC) #3
Johnni Winther
https://codereview.chromium.org/1149973004/diff/1/pkg/compiler/lib/src/resolution/send_resolver.dart File pkg/compiler/lib/src/resolution/send_resolver.dart (right): https://codereview.chromium.org/1149973004/diff/1/pkg/compiler/lib/src/resolution/send_resolver.dart#newcode205 pkg/compiler/lib/src/resolution/send_resolver.dart:205: assert(invariant(node, false, message: "Unexpected assert.")); On 2015/05/22 10:08:36, karlklose ...
5 years, 7 months ago (2015-05-22 12:24:59 UTC) #4
Johnni Winther
5 years, 7 months ago (2015-05-22 12:25:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
562eefcb55d11488e4f985c5d6d7108ae4730fb8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698