Start to compute SendStructure in resolution.

pkg/compiler/lib/src/resolution/send_resolver.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.semantics_visitor;
 
 enum SendStructureKind {
   GET,
   SET,
   INVOKE,
@@ skipping 178 matching lines @@
       } else {
         return new StaticAccess.topLevelMethod(element);
       }
     } else {
       return internalError(
           node, "Unhandled resolved property access: $element");
     }
   }
 
   SendStructure computeSendStructure(Send node) {
+    SendStructure sendStructure = elements.getSendStructure(node);
+    if (sendStructure != null) {
+      return sendStructure;
+    }
+
     if (elements.isAssert(node)) {
+      assert(invariant(node, false, message: "Unexpected assert."));

[karlklose, 2015/05/22 10:08:36]

Shouldn't we always throw instead of creating structures here?

[Johnni Winther, 2015/05/22 12:24:58]

Done.

       if (!node.arguments.isEmpty && node.arguments.tail.isEmpty) {
         return const AssertStructure();
       } else {
         return const InvalidAssertStructure();
       }
     }
 
     AssignmentOperator assignmentOperator;
     UnaryOperator unaryOperator;
     BinaryOperator binaryOperator;
     IncDecOperator incDecOperator;
 
     if (node.isOperator) {
       String operatorText = node.selector.asOperator().source;
       if (operatorText == 'is') {
+        assert(invariant(node, false, message: "Unexpected is test."));
         if (node.isIsNotCheck) {
           return new IsNotStructure(
               elements.getType(node.arguments.single.asSend().receiver));
         } else {
           return new IsStructure(elements.getType(node.arguments.single));
         }
       } else if (operatorText == 'as') {
+        assert(invariant(node, false, message: "Unexpected as cast."));
         return new AsStructure(elements.getType(node.arguments.single));
       } else if (operatorText == '&&') {
+        assert(invariant(node, false, message: "Unexpected logical and."));
         return const LogicalAndStructure();
       } else if (operatorText == '||') {
+        assert(invariant(node, false, message: "Unexpected logical or."));
         return const LogicalOrStructure();
       }
     }
 
     SendStructureKind kind;
 
     if (node.asSendSet() != null) {
       SendSet sendSet = node.asSendSet();
       String operatorText = sendSet.assignmentOperator.source;
       if (sendSet.isPrefix || sendSet.isPostfix) {
@@ skipping 695 matching lines @@
       return internalError(node, "Unexpected variable $element.");
     }
     if (element.isConst) {
       ConstantExpression constant = elements.getConstant(element.initializer);
       return new ConstantVariableStructure(kind, node, element, constant);
     } else {
       return new NonConstantVariableStructure(kind, node, element);
     }
   }
 }