Refactoring resolution of local access and unqualified access of statics

Refactoring resolution of local access and unqualified access of statics

BUG=
R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/58896b74ce50615114a006282e5b353885eca385

Reverted: https://github.com/dart-lang/sdk/commit/1807369aa14f16bdcf0f23fc7d0091d04dbdd1f9

Committed: https://github.com/dart-lang/sdk/commit/6fc35928429253a044c291e770d4d7e8f7fddce2

[Johnni Winther, 2015-06-07 11:38:10]

johnniwinther@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2015-06-08 09:05:30]

LGTM.

https://codereview.chromium.org/1149403009/diff/1/pkg/compiler/lib/src/helper...
File pkg/compiler/lib/src/helpers/trace.dart (right):

https://codereview.chromium.org/1149403009/diff/1/pkg/compiler/lib/src/helper...
pkg/compiler/lib/src/helpers/trace.dart:56: traceExceptions(List<String>
exceptions) {
Please add some documentation.

https://codereview.chromium.org/1149403009/diff/1/pkg/compiler/lib/src/helper...
pkg/compiler/lib/src/helpers/trace.dart:59: return
stackTrace.contains(exception);
'return !exceptions.any(stackTrace.contains);'

https://codereview.chromium.org/1149403009/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1149403009/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:880: message: "Unexpected staticall
resolved target '$target'."));
'staticall' -> 'statically'.

https://codereview.chromium.org/1149403009/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:1561: reportHere(compiler, node,
'handleStaticOrTopLevelAccess:$element (${element.isErroneous})');
Debug code?

[Johnni Winther, 2015-06-08 09:36:15]

https://codereview.chromium.org/1149403009/diff/1/pkg/compiler/lib/src/helper...
File pkg/compiler/lib/src/helpers/trace.dart (right):

https://codereview.chromium.org/1149403009/diff/1/pkg/compiler/lib/src/helper...
pkg/compiler/lib/src/helpers/trace.dart:56: traceExceptions(List<String>
exceptions) {
On 2015/06/08 09:05:30, karlklose wrote:
> Please add some documentation.

Done.

https://codereview.chromium.org/1149403009/diff/1/pkg/compiler/lib/src/helper...
pkg/compiler/lib/src/helpers/trace.dart:59: return
stackTrace.contains(exception);
On 2015/06/08 09:05:30, karlklose wrote:
> 'return !exceptions.any(stackTrace.contains);'

Done.

https://codereview.chromium.org/1149403009/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1149403009/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:880: message: "Unexpected staticall
resolved target '$target'."));
On 2015/06/08 09:05:30, karlklose wrote:
> 'staticall' -> 'statically'.

Done.

https://codereview.chromium.org/1149403009/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:1561: reportHere(compiler, node,
'handleStaticOrTopLevelAccess:$element (${element.isErroneous})');
On 2015/06/08 09:05:30, karlklose wrote:
> Debug code?

Yes! Removed.

[Johnni Winther, 2015-06-08 09:54:07]

Committed patchset #3 (id:40001) manually as
58896b74ce50615114a006282e5b353885eca385 (presubmit successful).

[Johnni Winther, 2015-06-08 12:17:41]

PTAL @ the last patch

[karlklose, 2015-06-08 12:34:22]

Patch set 5 LGTM.

[Johnni Winther, 2015-06-08 12:52:01]

Committed patchset #7 (id:110001) manually as
6fc35928429253a044c291e770d4d7e8f7fddce2 (presubmit successful).