Refactoring resolution of local access and unqualified access of statics

tests/compiler/dart2js/semantic_visitor_test_send_data.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.semantics_visitor_test;
 
 const Map<String, List<Test>> SEND_TESTS = const {
   'Parameters': const [
     // Parameters
     const Test('m(o) => o;',
@@ skipping 42 matching lines @@
   'Local functions': const [
     // Local functions
     const Test('m() { o(a, b) {}; return o; }',
         const Visit(VisitKind.VISIT_LOCAL_FUNCTION_GET,
                     element: 'function(m#o)')),
     const Test('m() { o(a, b) {}; o(null, 42); }',
         const Visit(VisitKind.VISIT_LOCAL_FUNCTION_INVOKE,
                     element: 'function(m#o)',
                     arguments: '(null,42)',
                     selector: 'CallStructure(arity=2)')),
+    const Test('m() { o(a) {}; o(null, 42); }',
+        const Visit(VisitKind.VISIT_LOCAL_FUNCTION_INCOMPATIBLE_INVOKE,
+                    element: 'function(m#o)',
+                    arguments: '(null,42)',
+                    selector: 'CallStructure(arity=2)')),
     // TODO(johnniwinther): Expect [VISIT_LOCAL_FUNCTION_SET] instead.
     const Test('m() { o(a, b) {}; o = 42; }',
         const Visit(VisitKind.VISIT_UNRESOLVED_SET,
                     name: 'o',
                     rhs: '42')),
   ],
   'Static fields': const [
     // Static fields
     const Test(
         '''
@@ skipping 270 matching lines @@
         ''',
         const Visit(VisitKind.VISIT_UNRESOLVED_GET,
                     name: 'o')),
     const Test.clazz(
         '''
         class C {
           static set o(_) {}
           m() => o;
         }
         ''',
-        const Visit(VisitKind.VISIT_UNRESOLVED_GET,
-                    name: 'o')),
+        const Visit(VisitKind.VISIT_STATIC_SETTER_GET,
+                    element: 'setter(C#o)')),
+
     const Test.clazz(
         '''
         class C {
           static set o(_) {}
           m() => C.o;
         }
         ''',
         const Visit(VisitKind.VISIT_UNRESOLVED_GET,
                     name: 'o')),
     const Test.prefix(
@@ skipping 90 matching lines @@
         const Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,
                     name: 'o',
                     arguments: '(null,42)')),
     const Test.clazz(
         '''
         class C {
           static set o(_) {}
           m() { o(null, 42); }
         }
         ''',
-        const Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,
-                    name: 'o',
+        const Visit(VisitKind.VISIT_STATIC_SETTER_INVOKE,
+                    element: 'setter(C#o)',
                     arguments: '(null,42)')),
     const Test.clazz(
         '''
         class C {
           static set o(_) {}
           m() { C.o(null, 42); }
         }
         ''',
         const Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,
                     name: 'o',
@@ skipping 236 matching lines @@
         m() => p.o;
         ''',
         const Visit(VisitKind.VISIT_TOP_LEVEL_GETTER_GET,
                     element: 'getter(o)')),
     // TODO(johnniwinther): Expect [VISIT_TOP_LEVEL_SETTER_GET] instead.
     const Test(
         '''
         set o(_) {}
         m() => o;
         ''',
-        const Visit(VisitKind.VISIT_UNRESOLVED_GET,
-                    name: 'o')),
+        const Visit(VisitKind.VISIT_TOP_LEVEL_SETTER_GET,
+                    element: 'setter(o)')),
     const Test.prefix(
         '''
         set o(_) {}
         ''',
         '''
         m() => p.o;
         ''',
         const Visit(VisitKind.VISIT_UNRESOLVED_GET,
                     name: 'o')),
     // TODO(johnniwinther): Expect [VISIT_TOP_LEVEL_GETTER_SET] instead.
@@ skipping 44 matching lines @@
         'm() { p.o(null, 42); }',
         const Visit(VisitKind.VISIT_TOP_LEVEL_GETTER_INVOKE,
                     element: 'getter(o)',
                     arguments: '(null,42)')),
     // TODO(johnniwinther): Expected [VISIT_TOP_LEVEL_SETTER_INVOKE] instead.
     const Test(
         '''
         set o(_) {}
         m() => o(null, 42);
         ''',
-        const Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,
-                    name: 'o',
+        const Visit(VisitKind.VISIT_TOP_LEVEL_SETTER_INVOKE,
+                    element: 'setter(o)',
                     arguments: '(null,42)')),
     const Test.prefix(
         '''
         set o(_) {}
         ''',
         'm() { p.o(null, 42); }',
         const Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,
                     name: 'o',
                     arguments: '(null,42)')),
   ],
@@ skipping 2702 matching lines @@
         '''
         m(a) => a ??= 42;
         ''',
         const Visit(
             VisitKind.VISIT_PARAMETER_COMPOUND,
             element: 'parameter(m#a)',
             operator: '??=',
             rhs: '42')),
   ],
 };