Make identical an external function and make it throw in both runtimes, as they both recognize it.

Make identical an external function and make it throw in both runtimes, as they both recognize it.
Committed: https://code.google.com/p/dart/source/detail?r=15956

[ngeoffray, 2012-12-10 13:59:43]

Fixes issue http://code.google.com/p/dart/issues/detail?id=6380.

[kasperl, 2012-12-10 14:01:29]

LGTM.

[srdjan, 2012-12-10 19:58:44]

LGTM

https://codereview.chromium.org/11489011/diff/1/runtime/lib/identical_patch.dart
File runtime/lib/identical_patch.dart (right):

https://codereview.chromium.org/11489011/diff/1/runtime/lib/identical_patch.d...
runtime/lib/identical_patch.dart:6: throw new Error('Should not reach the body
of identical');
This should be a native call instead of throw.

[ngeoffray, 2012-12-10 20:26:38]

https://codereview.chromium.org/11489011/diff/1/runtime/lib/identical_patch.dart
File runtime/lib/identical_patch.dart (right):

https://codereview.chromium.org/11489011/diff/1/runtime/lib/identical_patch.d...
runtime/lib/identical_patch.dart:6: throw new Error('Should not reach the body
of identical');
On 2012/12/10 19:58:44, srdjan wrote:
> This should be a native call instead of throw.

Any reason why? Do you mind if I land this CL (all tests pass with the VM), and
let you change it? I can change the throw and use '===' like it was before if
you prefer.

[srdjan, 2012-12-10 21:24:51]

https://codereview.chromium.org/11489011/diff/1/runtime/lib/identical_patch.dart
File runtime/lib/identical_patch.dart (right):

https://codereview.chromium.org/11489011/diff/1/runtime/lib/identical_patch.d...
runtime/lib/identical_patch.dart:6: throw new Error('Should not reach the body
of identical');
On 2012/12/10 20:26:39, ngeoffray wrote:
> On 2012/12/10 19:58:44, srdjan wrote:
> > This should be a native call instead of throw.
> 
> Any reason why? Do you mind if I land this CL (all tests pass with the VM),
and
> let you change it? I can change the throw and use '===' like it was before if
> you prefer.

We should not mandate inlining/intrinsification of a a method in order to be
able to run. 
Yes, land it and I will fix it on VM side.

[ngeoffray, 2012-12-11 09:21:44]

https://codereview.chromium.org/11489011/diff/1/runtime/lib/identical_patch.dart
File runtime/lib/identical_patch.dart (right):

https://codereview.chromium.org/11489011/diff/1/runtime/lib/identical_patch.d...
runtime/lib/identical_patch.dart:6: throw new Error('Should not reach the body
of identical');
On 2012/12/10 21:24:51, srdjan wrote:
> On 2012/12/10 20:26:39, ngeoffray wrote:
> > On 2012/12/10 19:58:44, srdjan wrote:
> > > This should be a native call instead of throw.
> > 
> > Any reason why? Do you mind if I land this CL (all tests pass with the VM),
> and
> > let you change it? I can change the throw and use '===' like it was before
if
> > you prefer.
> 
> We should not mandate inlining/intrinsification of a a method in order to be
> able to run. 

Makes sense.

> Yes, land it and I will fix it on VM side.

OK, thanks Srdjan.