Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: runtime/lib/identical_patch.dart

Issue 11489011: Make identical an external function and make it throw in both runtimes, as they both recognize it. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/lib_sources.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/identical_patch.dart
===================================================================
--- runtime/lib/identical_patch.dart (revision 0)
+++ runtime/lib/identical_patch.dart (revision 0)
@@ -0,0 +1,7 @@
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+patch bool identical(Object a, Object b) {
+ throw new Error('Should not reach the body of identical');
srdjan 2012/12/10 19:58:44 This should be a native call instead of throw.
ngeoffray 2012/12/10 20:26:39 Any reason why? Do you mind if I land this CL (all
srdjan 2012/12/10 21:24:51 We should not mandate inlining/intrinsification of
ngeoffray 2012/12/11 09:21:44 Makes sense.
+}
« no previous file with comments | « no previous file | runtime/lib/lib_sources.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698