Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 11481002: Cleanups based on Kevin's and Florian's suggestions. (Closed)

Created:
8 years ago by srdjan
Modified:
8 years ago
CC:
reviews_dartlang.org, Florian Schneider
Visibility:
Public.

Description

Cleanups based on Kevin's and Florian's suggestions. Committed: https://code.google.com/p/dart/source/detail?r=15850

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -20 lines) Patch
M runtime/vm/code_generator.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 6 chunks +8 lines, -10 lines 0 comments Download
M runtime/vm/dart_entry.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_entry.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/vm/debugger.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
8 years ago (2012-12-06 21:30:51 UTC) #1
Florian Schneider
LGTM.
8 years ago (2012-12-07 09:46:30 UTC) #2
Kevin Millikin (Google)
8 years ago (2012-12-07 11:01:27 UTC) #3
LGTM and thanks.

Powered by Google App Engine
This is Rietveld 408576698