Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: runtime/vm/dart_entry.cc

Issue 11481002: Cleanups based on Kevin's and Florian's suggestions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_entry.h ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_entry.cc
===================================================================
--- runtime/vm/dart_entry.cc (revision 15847)
+++ runtime/vm/dart_entry.cc (working copy)
@@ -134,12 +134,12 @@
}
-RawString* ArgumentsDescriptor::NameAt(intptr_t index) const {
- String& result = String::Handle();
- result ^= array_.At(kFirstNamedEntryIndex +
- (index * kNamedEntrySize) +
- kNameOffset);
- return result.raw();
+bool ArgumentsDescriptor::MatchesNameAt(intptr_t index,
+ const String& other) const {
+ const intptr_t offset = kFirstNamedEntryIndex +
+ (index * kNamedEntrySize) +
+ kNameOffset;
+ return array_.At(offset) == other.raw();
}
« no previous file with comments | « runtime/vm/dart_entry.h ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698