Issue 11478031: Fix KeyboardEvent constructor to default to empty string for keyIdentifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11478031: Fix KeyboardEvent constructor to default to empty string for keyIdentifier. (Closed)

Created:
8 years ago by Emily Fortuna

Modified:
8 years ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix KeyboardEvent constructor to default to empty string for keyIdentifier. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15861

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -141 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	9 chunks	+1 line, -138 lines	1 comment	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/templates/html/dart2js/impl_KeyboardEvent.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/templates/html/dartium/impl_KeyboardEvent.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

TBR https://codereview.chromium.org/11478031/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (left): https://codereview.chromium.org/11478031/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#oldcode5552 sdk/lib/html/dart2js/html_dart2js.dart:5552: * Represents an HTML <div> element. This is ...

8 years ago (2012-12-07 20:23:24 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages