sdk/lib/html/dartium/html_dartium.dart - Issue 11478031: Fix KeyboardEvent constructor to default to empty string for keyIdentifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 11478031: Fix KeyboardEvent constructor to default to empty string for keyIdentifier. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« sdk/lib/html/dart2js/html_dart2js.dart ('K') | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/html/templates/html/dart2js/impl_KeyboardEvent.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/html/dartium/html_dartium.dart

diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart

index c31c84f7fbef003b417ed23a58491b397b9a9369..d3434c7fa321a31f0a29bd87eba34b717ccf3a72 100644

--- a/sdk/lib/html/dartium/html_dartium.dart

+++ b/sdk/lib/html/dartium/html_dartium.dart

@@ -13442,7 +13442,7 @@ class KeyboardEvent extends UIEvent {

factory KeyboardEvent(String type, Window view,

[bool canBubble = true, bool cancelable = true,

- String keyIdentifier = null, int keyLocation = 1, bool ctrlKey = false,

+ String keyIdentifier = "", int keyLocation = 1, bool ctrlKey = false,

bool altKey = false, bool shiftKey = false, bool metaKey = false,

bool altGraphKey = false]) {

final e = document.$dom_createEvent("KeyboardEvent");