Issue 11474048: pipeInputToInput should be resilient to stream closure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11474048: pipeInputToInput should be resilient to stream closure. (Closed)

Created:
8 years ago by nweiz

Modified:
8 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pipeInputToInput should be resilient to stream closure. Committed: https://code.google.com/p/dart/source/detail?r=15880

Patch Set 2 : Code review change. #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	utils/pub/io.dart	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM after change. https://codereview.chromium.org/11474048/diff/1/utils/pub/io.dart File utils/pub/io.dart (right): https://codereview.chromium.org/11474048/diff/1/utils/pub/io.dart#newcode623 utils/pub/io.dart:623: if (!sink.closed) sink.write(source.read()); Should do the ...

8 years ago (2012-12-08 03:35:33 UTC) #2

nweiz

8 years ago (2012-12-08 03:38:04 UTC) #3

https://codereview.chromium.org/11474048/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/11474048/diff/1/utils/pub/io.dart#newcode623
utils/pub/io.dart:623: if (!sink.closed) sink.write(source.read());
On 2012/12/08 03:35:33, Bob Nystrom wrote:
> Should do the read() even if it's closed.
> 
> Also, maybe log this? Is it unexpected for this to happen?

I think it's more or less "business as usual" for streams. Probably not worth
logging, as it's very hard to know what the context is and may provide a high
volume of low-utility information.

Expand Messages | Collapse Messages

Issue 11474048: pipeInputToInput should be resilient to stream closure. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review change. #

Messages