Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: utils/pub/io.dart

Issue 11474048: pipeInputToInput should be resilient to stream closure. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review change. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/io.dart
diff --git a/utils/pub/io.dart b/utils/pub/io.dart
index 0c30c885dbb85046ad2d7999ee172b869224e213..06f818d3264189a9ba8e52ce2f84a3f8b6ad23c0 100644
--- a/utils/pub/io.dart
+++ b/utils/pub/io.dart
@@ -619,7 +619,12 @@ Future pipeInputToInput(InputStream source, ListInputStream sink) {
sink.markEndOfStream();
completer.complete(null);
};
- source.onData = () => sink.write(source.read());
+ source.onData = () {
+ // Even if the sink is closed and we aren't going to do anything with more
+ // data, we still need to drain it from source to work around issue 7218.
+ var data = source.read();
+ if (!sink.closed) sink.write(data);
+ };
// TODO(nweiz): propagate this error to the sink. See issue 3657.
source.onError = (e) { throw e; };
return completer.future;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698