Make ScriptProcessorNode not a proper event (because it isn't). This fixes the last of the static a…

Make ScriptProcessorNode not a proper event (because it isn't). This fixes the last of the static analysis errors.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=15923

[blois, 2012-12-07 23:40:00]

https://codereview.chromium.org/11469039/diff/4001/sdk/lib/html/scripts/htmle...
File sdk/lib/html/scripts/htmleventgenerator.py (right):

https://codereview.chromium.org/11469039/diff/4001/sdk/lib/html/scripts/htmle...
sdk/lib/html/scripts/htmleventgenerator.py:194: use_idl_event_style =
set(['ScriptProcessorNode'])
The name seems a bit odd- this is basically the converse of
_html_explicit_event_classes.

https://codereview.chromium.org/11469039/diff/4001/sdk/lib/html/templates/htm...
File sdk/lib/html/templates/html/dart2js/impl_ScriptProcessorNode.darttemplate
(right):

https://codereview.chromium.org/11469039/diff/4001/sdk/lib/html/templates/htm...
sdk/lib/html/templates/html/dart2js/impl_ScriptProcessorNode.darttemplate:7:
part of web_audio;
Can use part of $LIBRARYNAME; instead.

Why not combine this and the dartium one?

[Emily Fortuna, 2012-12-07 23:58:22]

PTAL

https://codereview.chromium.org/11469039/diff/4001/sdk/lib/html/scripts/htmle...
File sdk/lib/html/scripts/htmleventgenerator.py (right):

https://codereview.chromium.org/11469039/diff/4001/sdk/lib/html/scripts/htmle...
sdk/lib/html/scripts/htmleventgenerator.py:194: use_idl_event_style =
set(['ScriptProcessorNode'])
On 2012/12/07 23:40:00, blois wrote:
> The name seems a bit odd- this is basically the converse of
> _html_explicit_event_classes.

No. The items in "use_idl_event_style" have attr.type.id == 'EventListener' as
true. It is _not_ the case that all attrs that are EventListeners and are not in
_html_explicit_event_classes should have the "non-dart" event styles (that would
be all of the classes that we're currently dart-ifying), and we're not *adding*
an "on" method to ScriptProcessorNode, so it shouldn't be part of the
_html_explicit_event_classes list.

I could rename _html_explicit_event_classes as something like
"event_exception_classes", but then that just makes the logic on lines 217 and
in the other file more complicated (and less straigforward).

https://codereview.chromium.org/11469039/diff/4001/sdk/lib/html/templates/htm...
File sdk/lib/html/templates/html/dart2js/impl_ScriptProcessorNode.darttemplate
(right):

https://codereview.chromium.org/11469039/diff/4001/sdk/lib/html/templates/htm...
sdk/lib/html/templates/html/dart2js/impl_ScriptProcessorNode.darttemplate:7:
part of web_audio;
On 2012/12/07 23:40:00, blois wrote:
> Can use part of $LIBRARYNAME; instead.
> 
> Why not combine this and the dartium one?
Good point. these originally were going to diverge more, but they didn't so I
forgot to recombine them.

[blois, 2012-12-10 17:45:52]

lgtm