Make ScriptProcessorNode not a proper event (because it isn't). This fixes the last of the static a…

sdk/lib/html/scripts/htmleventgenerator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides functionality to generate dart:html event classes."""
 
 import logging
 
 _logger = logging.getLogger('dartgenerator')
@@ skipping 169 matching lines @@
   'write': 'write',
   'writeend': 'writeEnd',
   'writestart': 'writeStart'
 }
 
 # These classes require an explicit declaration for the "on" method even though
 # they don't declare any unique events, because the concrete class hierarchy
 # doesn't match the interface hierarchy.
 _html_explicit_event_classes = set(['DocumentFragment'])
 
+# These classes are not really proper events targets, even though the IDL claims
+# they are. We don't make these the dart-style event names since they're not
+# really events -- the user uses them the same way they would use any other
+# event in JavaScript -- by assigning an event handler function.
+use_idl_event_style = set(['ScriptProcessorNode'])

[blois, 2012/12/07 23:40:00]

The name seems a bit odd- this is basically the converse of
_html_explicit_event_classes.

[Emily Fortuna, 2012/12/07 23:58:22]

No. The items in "use_idl_event_style" have attr.type.id == 'EventListener' as
true. It is _not_ the case that all attrs that are EventListeners and are not in
_html_explicit_event_classes should have the "non-dart" event styles (that would
be all of the classes that we're currently dart-ifying), and we're not *adding*
an "on" method to ScriptProcessorNode, so it shouldn't be part of the
_html_explicit_event_classes list.

I could rename _html_explicit_event_classes as something like
"event_exception_classes", but then that just makes the logic on lines 217 and
in the other file more complicated (and less straigforward).

+
 class HtmlEventGenerator(object):
 
   def __init__(self, database, renamer, template_loader):
     self._event_classes = set()
     self._database = database
     self._renamer = renamer
     self._template_loader = template_loader
 
   def ProcessInterface(self, interface, html_interface_name, custom_events,
                        events_implementation_emitter):
     event_names = set([attr.id[2:] for attr in interface.attributes
                   if attr.type.id == 'EventListener'])
 
     # Document and DocumentFragment actually derive from Element, so omit
     # any events which are duplicated with that.
     if interface.id == 'Document' or interface.id == 'DocumentFragment':
       element_interface = self._database.GetInterface('Element')
       for attr in element_interface.attributes:
         if attr.type.id == 'EventListener' and attr.id[2:] in event_names:
           event_names.remove(attr.id[2:])
 
-    if not event_names and interface.id not in _html_explicit_event_classes:
+    if interface.id in use_idl_event_style or (
+        not event_names and interface.id not in _html_explicit_event_classes):
       return None
 
     self._event_classes.add(interface.id)
     events_class_name = html_interface_name + 'Events'
     parent_events_class_name = self._GetParentEventsClassName(interface)
 
     if not event_names:
       return parent_events_class_name
 
     template_file = 'impl_%s.darttemplate' % events_class_name
@@ skipping 42 matching lines @@
     parent_events_class_name = 'Events'
     interfaces_with_events = set()
     for parent in self._database.Hierarchy(interface):
       if parent != interface and parent.id in self._event_classes:
         parent_name = self._renamer.RenameInterface(parent)
         parent_events_class_name = parent_name + 'Events'
         interfaces_with_events.add(parent)
     if len(interfaces_with_events) > 1:
       raise Exception('Only one parent event class allowed ' + interface.id)
     return parent_events_class_name