Issue 11469036: - Create frame work for adding read only handles for symbols in the VM isolate

Issue 11469036: - Create frame work for adding read only handles for symbols in the VM isolate (Closed)

Created:
8 years ago by siva

Modified:
8 years ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

- Create frame work for adding read only handles for symbols in the VM isolate - Make the symbol corresponding to "." use this frame work and change code which was creating a handle to use the read only handle instead. (Once we agree on this frame work we could create similar read only handles for the frequently used symbols) Committed: https://code.google.com/p/dart/source/detail?r=15920

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -29 lines)			Patch
M	vm/class_finalizer.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	vm/dart_api_impl.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	vm/dart_entry.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	vm/flow_graph_builder.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	vm/handles.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	vm/parser.cc	View	1 2	8 chunks	+13 lines, -20 lines	0 comments	Download
M	vm/symbols.h	View		3 chunks	+18 lines, -0 lines	0 comments	Download
M	vm/symbols.cc	View		3 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM with comment. https://chromiumcodereview.appspot.com/11469036/diff/7001/vm/parser.cc File vm/parser.cc (right): https://chromiumcodereview.appspot.com/11469036/diff/7001/vm/parser.cc#newcode1634 vm/parser.cc:1634: const String& ctor_suffix = String::Handle( Looks ...

8 years ago (2012-12-08 00:01:15 UTC) #2

siva

8 years ago (2012-12-08 00:13:56 UTC) #3

Thanks.

https://chromiumcodereview.appspot.com/11469036/diff/7001/vm/parser.cc
File vm/parser.cc (right):

https://chromiumcodereview.appspot.com/11469036/diff/7001/vm/parser.cc#newcod...
vm/parser.cc:1634: const String& ctor_suffix = String::Handle(
Nice.

I fixed it.


On 2012/12/08 00:01:15, hausner wrote:
> Looks like this could be simplified now, roughly like this:
> 
> ctor_name = ... super_class.Name()
> ctor_name.Concat(ctor_name, dot);
> if (CurrentToken() == Token.kPeriod) {
>   ctor_name.Concat(ctor_name, ExpectIdentifier(...));
> }

https://chromiumcodereview.appspot.com/11469036/diff/7001/vm/parser.cc#newcod...
vm/parser.cc:1856: const String& ctor_suffix = String::Handle(
On 2012/12/08 00:01:15, hausner wrote:
> ditto.

Done.

https://chromiumcodereview.appspot.com/11469036/diff/7001/vm/parser.cc#newcod...
vm/parser.cc:2957: const String& ctor_suffix = String::Handle(
On 2012/12/08 00:01:15, hausner wrote:
> ditto

Done.

Expand Messages | Collapse Messages