Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: vm/symbols.cc

Issue 11469036: - Create frame work for adding read only handles for symbols in the VM isolate (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/symbols.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/symbols.cc
===================================================================
--- vm/symbols.cc (revision 15861)
+++ vm/symbols.cc (working copy)
@@ -4,6 +4,8 @@
#include "vm/symbols.h"
+#include "vm/handles.h"
+#include "vm/handles_impl.h"
#include "vm/isolate.h"
#include "vm/object.h"
#include "vm/object_store.h"
@@ -15,7 +17,13 @@
namespace dart {
RawString* Symbols::predefined_[Symbols::kMaxId];
+VMHandles Symbols::predefined_handles_;
+#define DEFINE_SYMBOL_HANDLE(symbol) \
+ String* Symbols::symbol##_handle_ = NULL;
+PREDEFINED_SYMBOL_HANDLES_LIST(DEFINE_SYMBOL_HANDLE)
+#undef DEFINE_SYMBOL_HANDLE
+
static const char* names[] = {
NULL,
@@ -59,6 +67,13 @@
ASSERT(kMaxPredefinedId + c < kMaxId);
predefined_[kMaxPredefinedId + c] = FromUTF32(&c, 1);
}
+
+#define INITIALIZE_SYMBOL_HANDLE(symbol) \
+ symbol##_handle_ = reinterpret_cast<String*>( \
+ predefined_handles_.AllocateScopedHandle()); \
+ *symbol##_handle_ = symbol();
+PREDEFINED_SYMBOL_HANDLES_LIST(INITIALIZE_SYMBOL_HANDLE)
+#undef INITIALIZE_SYMBOL_HANDLE
}
« no previous file with comments | « vm/symbols.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698