Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1146813009: Introduce WorldImpact (Closed)

Created:
5 years, 6 months ago by Johnni Winther
Modified:
5 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment. #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+352 lines, -117 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 6 chunks +14 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 15 chunks +40 lines, -33 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 6 chunks +40 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 5 chunks +26 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 2 chunks +15 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 7 chunks +178 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_common.dart View 11 chunks +16 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 chunk +6 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 6 months ago (2015-06-01 09:57:50 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1146813009/diff/1/pkg/compiler/lib/src/resolution/registry.dart File pkg/compiler/lib/src/resolution/registry.dart (right): https://codereview.chromium.org/1146813009/diff/1/pkg/compiler/lib/src/resolution/registry.dart#newcode457 pkg/compiler/lib/src/resolution/registry.dart:457: //world.registerGetOfStaticFunction(element); Remove code in comments (also below).
5 years, 6 months ago (2015-06-01 10:50:24 UTC) #3
Johnni Winther
https://codereview.chromium.org/1146813009/diff/1/pkg/compiler/lib/src/resolution/registry.dart File pkg/compiler/lib/src/resolution/registry.dart (right): https://codereview.chromium.org/1146813009/diff/1/pkg/compiler/lib/src/resolution/registry.dart#newcode457 pkg/compiler/lib/src/resolution/registry.dart:457: //world.registerGetOfStaticFunction(element); On 2015/06/01 10:50:24, karlklose wrote: > Remove code ...
5 years, 6 months ago (2015-06-01 11:50:38 UTC) #4
Johnni Winther
5 years, 6 months ago (2015-06-01 12:43:41 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
96efb7bde854d4aa78ed8c79e573028f7cf6f2ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698