Introduce WorldImpact

pkg/compiler/lib/src/js_backend/backend.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 const VERBOSE_OPTIMIZER_HINTS = false;
 
 class JavaScriptItemCompilationContext extends ItemCompilationContext {
   final Set<HInstruction> boundsChecked = new Set<HInstruction>();
@@ skipping 1163 matching lines @@
   void registerClosureWithFreeTypeVariables(
       Element closure,
       Enqueuer enqueuer,
       Registry registry) {
     if (enqueuer.isResolutionQueue || methodNeedsRti(closure)) {
       registerComputeSignature(enqueuer, registry);
     }
   }
 
   void registerBoundClosure(Enqueuer enqueuer) {
-    enqueuer.registerInstantiatedClass(
-        boundClosureClass,
+    boundClosureClass.ensureResolved(compiler);
+    enqueuer.registerInstantiatedType(
+        boundClosureClass.rawType,
         // Precise dependency is not important here.
         compiler.globalDependencies);
   }
 
   void registerGetOfStaticFunction(Enqueuer enqueuer) {
-    enqueuer.registerInstantiatedClass(closureClass,
-                                       compiler.globalDependencies);
+    closureClass.ensureResolved(compiler);
+    enqueuer.registerInstantiatedType(
+        closureClass.rawType, compiler.globalDependencies);
   }
 
   void registerComputeSignature(Enqueuer enqueuer, Registry registry) {
     // Calls to [:computeSignature:] are generated by the emitter and we
     // therefore need to enqueue the used elements in the codegen enqueuer as
     // well as in the resolution enqueuer.
     enqueue(enqueuer, getSetRuntimeTypeInfo(), registry);
     enqueue(enqueuer, getGetRuntimeTypeInfo(), registry);
     enqueue(enqueuer, getComputeSignature(), registry);
     enqueue(enqueuer, getGetRuntimeTypeArguments(), registry);
@@ skipping 161 matching lines @@
   /// This method calls [registerBackendUse].
   void enqueueInResolution(Element e, Registry registry) {
     if (e == null) return;
     ResolutionEnqueuer enqueuer = compiler.enqueuer.resolution;
     enqueue(enqueuer, e, registry);
   }
 
   /// Register instantiation of [cls] in [enqueuer].
   ///
   /// This method calls [registerBackendUse].
-  void enqueueClass(Enqueuer enqueuer, Element cls, Registry registry) {
+  void enqueueClass(Enqueuer enqueuer, ClassElement cls, Registry registry) {
     if (cls == null) return;
     registerBackendUse(cls);
     helpersUsed.add(cls.declaration);
     if (cls.declaration != cls.implementation) {
       helpersUsed.add(cls.implementation);
     }
-    enqueuer.registerInstantiatedClass(cls, registry);
+    cls.ensureResolved(compiler);
+    enqueuer.registerInstantiatedType(cls.rawType, registry);
   }
 
-  void codegen(CodegenWorkItem work) {
+  WorldImpact codegen(CodegenWorkItem work) {
     Element element = work.element;
     if (compiler.elementHasCompileTimeError(element)) {
       generatedCode[element] = jsAst.js(
           "function () { throw new Error('Compile time error in $element') }");
-      return;
+      return const WorldImpact();
     }
     var kind = element.kind;
-    if (kind == ElementKind.TYPEDEF) return;
+    if (kind == ElementKind.TYPEDEF) {
+      return const WorldImpact();
+    }
     if (element.isConstructor && element.enclosingClass == jsNullClass) {
       // Work around a problem compiling JSNull's constructor.
-      return;
+      return const WorldImpact();
     }
     if (kind.category == ElementCategory.VARIABLE) {
       ConstantExpression initialValue =
           constants.getConstantForVariable(element);
       if (initialValue != null) {
         registerCompileTimeConstant(initialValue.value, work.registry);
         constants.addCompileTimeConstantForEmission(initialValue.value);
         // We don't need to generate code for static or top-level
         // variables. For instance variables, we may need to generate
         // the checked setter.
-        if (Elements.isStaticOrTopLevel(element)) return;
+        if (Elements.isStaticOrTopLevel(element)) {
+          return const WorldImpact();
+        }
       } else {
         // If the constant-handler was not able to produce a result we have to
         // go through the builder (below) to generate the lazy initializer for
         // the static variable.
         // We also need to register the use of the cyclic-error helper.
         compiler.enqueuer.codegen.registerStaticUse(getCyclicThrowHelper());
       }
     }
     generatedCode[element] = functionCompiler.compile(work);
+    return const WorldImpact();
   }
 
   native.NativeEnqueuer nativeResolutionEnqueuer(Enqueuer world) {
     return new native.NativeResolutionEnqueuer(world, compiler);
   }
 
   native.NativeEnqueuer nativeCodegenEnqueuer(Enqueuer world) {
     return new native.NativeCodegenEnqueuer(world, compiler, emitter);
   }
 
@@ skipping 1204 matching lines @@
   }
 
   void registerAsyncMarker(FunctionElement element,
                            Enqueuer enqueuer,
                            Registry registry) {
     if (element.asyncMarker == AsyncMarker.ASYNC) {
       enqueue(enqueuer, getAsyncHelper(), registry);
       enqueue(enqueuer, getCompleterConstructor(), registry);
       enqueue(enqueuer, getStreamIteratorConstructor(), registry);
     } else if (element.asyncMarker == AsyncMarker.SYNC_STAR) {
-      enqueuer.registerInstantiatedClass(getSyncStarIterable(), registry);
+      ClassElement clsSyncStarIterable = getSyncStarIterable();
+      clsSyncStarIterable.ensureResolved(compiler);
+      enqueuer.registerInstantiatedType(clsSyncStarIterable.rawType, registry);
       enqueue(enqueuer, getSyncStarIterableConstructor(), registry);
       enqueue(enqueuer, getEndOfIteration(), registry);
       enqueue(enqueuer, getYieldStar(), registry);
       enqueue(enqueuer, getSyncStarUncaughtError(), registry);
     } else if (element.asyncMarker == AsyncMarker.ASYNC_STAR) {
-      enqueuer.registerInstantiatedClass(getASyncStarController(), registry);
+      ClassElement clsASyncStarController = getASyncStarController();
+      clsASyncStarController.ensureResolved(compiler);
+      enqueuer.registerInstantiatedType(
+          clsASyncStarController.rawType, registry);
       enqueue(enqueuer, getAsyncStarHelper(), registry);
       enqueue(enqueuer, getStreamOfController(), registry);
       enqueue(enqueuer, getYieldSingle(), registry);
       enqueue(enqueuer, getYieldStar(), registry);
       enqueue(enqueuer, getASyncStarControllerConstructor(), registry);
       enqueue(enqueuer, getStreamIteratorConstructor(), registry);
     }
   }
 }
 
@@ skipping 272 matching lines @@
   }
 }
 
 /// Records that [constant] is used by the element behind [registry].
 class Dependency {
   final ConstantValue constant;
   final Element annotatedElement;
 
   const Dependency(this.constant, this.annotatedElement);
 }