Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11464025: dart2js: complain about missing part-of tags. (Closed)

Created:
8 years ago by ahe
Modified:
8 years ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org, Johnni Winther, karlklose
Visibility:
Public.

Description

dart2js: complain about missing part-of tags. BUG=http://dartbug.com/5888 Committed: https://code.google.com/p/dart/source/detail?r=15909

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Address review comments #

Messages

Total messages: 4 (0 generated)
ahe
8 years ago (2012-12-10 12:49:00 UTC) #1
ngeoffray
LGTM https://codereview.chromium.org/11464025/diff/5002/dart/sdk/lib/_internal/compiler/implementation/library_loader.dart File dart/sdk/lib/_internal/compiler/implementation/library_loader.dart (right): https://codereview.chromium.org/11464025/diff/5002/dart/sdk/lib/_internal/compiler/implementation/library_loader.dart#newcode275 dart/sdk/lib/_internal/compiler/implementation/library_loader.dart:275: compiler.onDeprecatedFeature(part, 'missing part-of tag'); Should onDeprecatedFeature check isPlatformLibrary? ...
8 years ago (2012-12-10 13:06:51 UTC) #2
ahe
PTAL https://codereview.chromium.org/11464025/diff/5002/dart/sdk/lib/_internal/compiler/implementation/library_loader.dart File dart/sdk/lib/_internal/compiler/implementation/library_loader.dart (right): https://codereview.chromium.org/11464025/diff/5002/dart/sdk/lib/_internal/compiler/implementation/library_loader.dart#newcode275 dart/sdk/lib/_internal/compiler/implementation/library_loader.dart:275: compiler.onDeprecatedFeature(part, 'missing part-of tag'); On 2012/12/10 13:06:51, ngeoffray ...
8 years ago (2012-12-10 13:29:32 UTC) #3
ngeoffray
8 years ago (2012-12-10 13:35:14 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698