dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart - Issue 11464025: dart2js: complain about missing part-of tags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 11464025: dart2js: complain about missing part-of tags. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/warnings.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

index 6e52485218e7478c23893f7e6d59794ec58dcfee..28379db9d7894c740fa0b660caab8f17308495bb 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

@@ -518,12 +518,13 @@ class ResolverTask extends CompilerTask {

Element otherMember = holder.lookupLocalMember(name);

if (otherMember != null) {

- compiler.onDeprecatedFeature(member, 'conflicting constructor');

- compiler.reportMessage(

- compiler.spanFromElement(otherMember),

- MessageKind.GENERIC.error(['This member conflicts with a'

- ' constructor.']),

- Diagnostic.INFO);

+ if (compiler.onDeprecatedFeature(member, 'conflicting constructor')) {

+ compiler.reportMessage(

+ compiler.spanFromElement(otherMember),

+ MessageKind.GENERIC.error(['This member conflicts with a'

+ ' constructor.']),

+ Diagnostic.INFO);

+ }

}