Fix asset and SDK path detection.

Fix asset and SDK path detection.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/pub/commit/99f642afe83077584f45ca40a99ef223ac724cd4

[Bob Nystrom, 2015-05-20 22:00:57]

lgtm

https://codereview.chromium.org/1145993003/diff/1/lib/src/io.dart
File lib/src/io.dart (right):

https://codereview.chromium.org/1145993003/diff/1/lib/src/io.dart#newcode480
lib/src/io.dart:480:
!path.url.basename(Platform.script.path).startsWith('pub.');
Document why this works. It's because the only *non* test processes will be
"pub(.dart)?.snapshot" or "pub.test(.dart)?.snapshot", right?

https://codereview.chromium.org/1145993003/diff/1/lib/src/io.dart#newcode513
lib/src/io.dart:513: /// The path to the root of pub's sources the pub repo.
"sources the" -> "sources in the"

https://codereview.chromium.org/1145993003/diff/1/lib/src/io.dart#newcode524
lib/src/io.dart:524: while (path.basename(script) != 'test') {
Maybe use path.split() and .lastIndexOf("test")?

https://codereview.chromium.org/1145993003/diff/1/lib/src/sdk.dart
File lib/src/sdk.dart (right):

https://codereview.chromium.org/1145993003/diff/1/lib/src/sdk.dart#newcode26
lib/src/sdk.dart:26: var aboveExecutable =
p.dirname(p.dirname(Platform.executable));
Document this.

[nweiz, 2015-05-21 00:42:30]

Code review changes

[nweiz, 2015-05-21 00:43:10]

https://codereview.chromium.org/1145993003/diff/1/lib/src/io.dart
File lib/src/io.dart (right):

https://codereview.chromium.org/1145993003/diff/1/lib/src/io.dart#newcode480
lib/src/io.dart:480:
!path.url.basename(Platform.script.path).startsWith('pub.');
On 2015/05/20 22:00:57, Bob Nystrom wrote:
> Document why this works. It's because the only *non* test processes will be
> "pub(.dart)?.snapshot" or "pub.test(.dart)?.snapshot", right?

Done.

https://codereview.chromium.org/1145993003/diff/1/lib/src/io.dart#newcode513
lib/src/io.dart:513: /// The path to the root of pub's sources the pub repo.
On 2015/05/20 22:00:57, Bob Nystrom wrote:
> "sources the" -> "sources in the"

Done.

https://codereview.chromium.org/1145993003/diff/1/lib/src/io.dart#newcode524
lib/src/io.dart:524: while (path.basename(script) != 'test') {
On 2015/05/20 22:00:57, Bob Nystrom wrote:
> Maybe use path.split() and .lastIndexOf("test")?

Done.

https://codereview.chromium.org/1145993003/diff/1/lib/src/sdk.dart
File lib/src/sdk.dart (right):

https://codereview.chromium.org/1145993003/diff/1/lib/src/sdk.dart#newcode26
lib/src/sdk.dart:26: var aboveExecutable =
p.dirname(p.dirname(Platform.executable));
On 2015/05/20 22:00:57, Bob Nystrom wrote:
> Document this.

Done.

[nweiz, 2015-05-21 00:43:19]

Committed patchset #2 (id:20001) manually as
99f642afe83077584f45ca40a99ef223ac724cd4 (presubmit successful).