Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: test/test_pub.dart

Issue 1145993003: Fix asset and SDK path detection. (Closed) Base URL: git@github.com:dart-lang/pub_test@master
Patch Set: Code review changes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/real_version_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/test_pub.dart
diff --git a/test/test_pub.dart b/test/test_pub.dart
index fb7164a59f96ee41333d859f8dddcb4e21425069..395d084f71b2511474d89dd22026a67b2193ceea 100644
--- a/test/test_pub.dart
+++ b/test/test_pub.dart
@@ -373,11 +373,6 @@ void _integration(String description, void body(), [Function testFn]) {
});
}
-/// Get the path to the root "pub/test" directory containing the pub
-/// tests.
-String get testDirectory =>
- p.absolute(p.dirname(libraryPath('test_pub')));
-
/// Schedules renaming (moving) the directory at [from] to [to], both of which
/// are assumed to be relative to [sandboxDir].
void scheduleRename(String from, String to) {
@@ -857,8 +852,7 @@ Map packageMap(String name, String version, [Map dependencies]) {
}
/// Resolves [target] relative to the path to pub's `test/asset` directory.
-String testAssetPath(String target) =>
- p.join(p.dirname(libraryPath('test_pub')), 'asset', target);
+String testAssetPath(String target) => p.join(pubRoot, 'test', 'asset', target);
/// Returns a Map in the format used by the pub.dartlang.org API to represent a
/// package version.
« no previous file with comments | « test/real_version_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698