Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1145913002: In constant evaluation, handle annotation referring to non-const constructor. (Closed)

Created:
5 years, 7 months ago by Paul Berry
Modified:
5 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

In constant evaluation, handle annotation referring to non-const constructor. We need to be more careful about this in the new task model, since the new task model is more aggressive about chasing dependencies, and we don't want constant evaluation to try to visit a non-const constructor. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e519fb8afb47d22fabdd7410f536e9c2b5000b43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 4 chunks +28 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 7 months ago (2015-05-20 02:40:23 UTC) #2
scheglov
LGTM
5 years, 7 months ago (2015-05-20 14:31:25 UTC) #3
Paul Berry
5 years, 7 months ago (2015-05-20 16:25:45 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e519fb8afb47d22fabdd7410f536e9c2b5000b43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698