In constant evaluation, handle annotation referring to non-const constructor.

pkg/analyzer/lib/src/generated/constant.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // This code was auto-generated, is not intended to be edited, and is subject to
 // significant change. Please see the README file for more information.
 
 library engine.constant;
 
 import 'dart:collection';
@@ skipping 352 matching lines @@
       // which case we skip it.
       if (elementAnnotation != null) {
         Element element = elementAnnotation.element;
         if (element is PropertyAccessorElement &&
             element.variable is VariableElementImpl) {
           // The annotation is a reference to a compile-time constant variable.
           // Just copy the evaluation result.
           VariableElementImpl variableElement =
               element.variable as VariableElementImpl;
           elementAnnotation.evaluationResult = variableElement.evaluationResult;
-        } else if (element is ConstructorElementImpl &&
+        } else if (element is ConstructorElementImpl && element.isConst &&
             constNode.arguments != null) {
           RecordingErrorListener errorListener = new RecordingErrorListener();
           CompilationUnit sourceCompilationUnit =
               constNode.getAncestor((node) => node is CompilationUnit);
           ErrorReporter errorReporter = new ErrorReporter(
               errorListener, sourceCompilationUnit.element.source);
           ConstantVisitor constantVisitor =
               new ConstantVisitor(this, errorReporter);
           DartObjectImpl result = evaluateConstructorCall(constNode,
               constNode.arguments.arguments, element, constantVisitor,
@@ skipping 94 matching lines @@
       if (elementAnnotation != null) {
         Element element = elementAnnotation.element;
         if (element is PropertyAccessorElement &&
             element.variable is VariableElementImpl) {
           // The annotation is a reference to a compile-time constant variable,
           // so it depends on the variable.
           callback(element.variable);
         } else if (element is ConstructorElementImpl && element.isConst) {
           // The annotation is a constructor invocation, so it depends on the
           // constructor.
-          // TODO(paulberry): make sure the right thing happens if the
-          // constructor is non-const.
           callback(element);
         } else {
           // This could happen in the event of invalid code.  The error will be
           // reported at constant evaluation time.
         }
       }
       if (constNode.arguments != null) {
         constNode.arguments.accept(referenceFinder);
       }
     } else {
@@ skipping 4718 matching lines @@
       return BoolState.from(_element == rightElement);
     } else if (rightOperand is DynamicState) {
       return BoolState.UNKNOWN_VALUE;
     }
     return BoolState.FALSE_STATE;
   }
 
   @override
   String toString() => _element == null ? "-unknown-" : _element.name;
 }