Issue 1145053004: Revert "Per-closure breakpoints; restructure breakpoint implementation to keep a list of conditions…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1145053004: Revert "Per-closure breakpoints; restructure breakpoint implementation to keep a list of conditions… (Closed)

Created:
5 years, 7 months ago by rmacnak

Modified:
5 years, 7 months ago

Reviewers:

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Per-closure breakpoints; restructure breakpoint implementation to keep a list of conditions." This reverts commit d37149ad3b988e62e7f87931a06d62de6be1645c. Committed: https://github.com/dart-lang/sdk/commit/e674f0dc62f8dfa4e6a27a416d6b2ec5c5c70010

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+298 lines, -814 lines)			Patch
M	runtime/observatory/lib/src/service/object.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	runtime/observatory/tests/service/break_on_activation_test.dart	View	1 chunk	+0 lines, -191 lines	0 comments	Download
M	runtime/observatory/tests/service/test_helper.dart	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/debugger.h	View	15 chunks	+60 lines, -125 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	44 chunks	+212 lines, -433 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	5 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/json_stream.h	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/json_stream.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/service.cc	View	7 chunks	+7 lines, -35 lines	0 comments	Download
M	runtime/vm/service_event.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 1 (0 generated)

rmacnak

5 years, 7 months ago (2015-05-22 00:21:03 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e674f0dc62f8dfa4e6a27a416d6b2ec5c5c70010 (presubmit successful).