Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: runtime/observatory/lib/src/service/object.dart

Issue 1145053004: Revert "Per-closure breakpoints; restructure breakpoint implementation to keep a list of conditions… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/observatory/tests/service/break_on_activation_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of service; 5 part of service;
6 6
7 /// An RpcException represents an exceptional event that happened 7 /// An RpcException represents an exceptional event that happened
8 /// while invoking an rpc. 8 /// while invoking an rpc.
9 abstract class RpcException implements Exception { 9 abstract class RpcException implements Exception {
10 RpcException(this.message); 10 RpcException(this.message);
(...skipping 1157 matching lines...) Expand 10 before | Expand all | Expand 10 after
1168 } 1168 }
1169 rethrow; 1169 rethrow;
1170 } 1170 }
1171 } 1171 }
1172 1172
1173 Future<ServiceObject> addBreakpointAtEntry(ServiceFunction function) { 1173 Future<ServiceObject> addBreakpointAtEntry(ServiceFunction function) {
1174 return invokeRpc('addBreakpointAtEntry', 1174 return invokeRpc('addBreakpointAtEntry',
1175 { 'functionId': function.id }); 1175 { 'functionId': function.id });
1176 } 1176 }
1177 1177
1178 Future<ServiceObject> addBreakOnActivation(Instance closure) {
1179 return invokeRpc('_addBreakpointAtActivation',
1180 { 'objectId': closure.id });
1181 }
1182
1183 Future removeBreakpoint(Breakpoint bpt) { 1178 Future removeBreakpoint(Breakpoint bpt) {
1184 return invokeRpc('removeBreakpoint', 1179 return invokeRpc('removeBreakpoint',
1185 { 'breakpointId': bpt.id }); 1180 { 'breakpointId': bpt.id });
1186 } 1181 }
1187 1182
1188 Future pause() { 1183 Future pause() {
1189 return invokeRpc('pause', {}); 1184 return invokeRpc('pause', {});
1190 } 1185 }
1191 1186
1192 Future resume() { 1187 Future resume() {
(...skipping 1925 matching lines...) Expand 10 before | Expand all | Expand 10 after
3118 var v = list[i]; 3113 var v = list[i];
3119 if ((v is ObservableMap) && _isServiceMap(v)) { 3114 if ((v is ObservableMap) && _isServiceMap(v)) {
3120 list[i] = owner.getFromMap(v); 3115 list[i] = owner.getFromMap(v);
3121 } else if (v is ObservableList) { 3116 } else if (v is ObservableList) {
3122 _upgradeObservableList(v, owner); 3117 _upgradeObservableList(v, owner);
3123 } else if (v is ObservableMap) { 3118 } else if (v is ObservableMap) {
3124 _upgradeObservableMap(v, owner); 3119 _upgradeObservableMap(v, owner);
3125 } 3120 }
3126 } 3121 }
3127 } 3122 }
OLDNEW
« no previous file with comments | « no previous file | runtime/observatory/tests/service/break_on_activation_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698