Issue 11445043: Fix type annotations on local variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11445043: Fix type annotations on local variables. (Closed)

Created:
8 years ago by Johnni Winther

Modified:
8 years ago

Reviewers:
karlklose, ahe, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix type annotations on local variables. BUG=http://dartbug.com/5348 Committed: https://code.google.com/p/dart/source/detail?r=15788

Patch Set 2 : Rebased #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		1 chunk	+9 lines, -1 line	2 comments	Download
	M	tests/co19/co19-dart2js.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Very nice! https://codereview.chromium.org/11445043/diff/5001/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/11445043/diff/5001/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode2067 sdk/lib/_internal/compiler/implementation/resolution/members.dart:2067: // the current scope. If the current ...

8 years ago (2012-12-09 20:46:56 UTC) #4

Johnni Winther

8 years ago (2012-12-11 14:22:58 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/11445043/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/11445043/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2067: // the
current scope. If the current scope is a [MethodScope] or
On 2012/12/09 20:46:56, ngeoffray wrote:
> it depends *on* the current scope.

Done in https://codereview.chromium.org/11415287/

Expand Messages | Collapse Messages

Issue 11445043: Fix type annotations on local variables. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Messages