Issue 11444018: Add a validator that checks package names.

Issue 11444018: Add a validator that checks package names. (Closed)

Created:
8 years ago by nweiz

Modified:
8 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a validator that checks package names. BUG=7045 Committed: https://code.google.com/p/dart/source/detail?r=15857

Patch Set 2 : Code review changes. #

Patch Set 3 : Fix tests. #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+164 lines, -8 lines)			Patch
M	utils/pub/io.dart	View		6 chunks	+8 lines, -8 lines	0 comments	Download
M	utils/pub/validator.dart	View		2 chunks	+2 lines, -0 lines	0 comments	Download
A	utils/pub/validator/name.dart	View	1	1 chunk	+73 lines, -0 lines	0 comments	Download
M	utils/tests/pub/validator_test.dart	View	1 2	4 chunks	+81 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

https://codereview.chromium.org/11444018/diff/1/utils/pub/validator/name.dart File utils/pub/validator/name.dart (right): https://codereview.chromium.org/11444018/diff/1/utils/pub/validator/name.dart#newcode44 utils/pub/validator/name.dart:44: errors.add("$description may not be empty."); We should discuss this, ...

8 years ago (2012-12-06 02:26:43 UTC) #2

nweiz

Changed as per our OOB discussion. PTAL. On 2012/12/06 02:26:43, Bob Nystrom wrote: > https://codereview.chromium.org/11444018/diff/1/utils/pub/validator/name.dart ...

8 years ago (2012-12-07 00:24:16 UTC) #3

Bob Nystrom

8 years ago (2012-12-07 17:07:43 UTC) #4

LGTM!

https://codereview.chromium.org/11444018/diff/6005/utils/tests/pub/validator_...
File utils/tests/pub/validator_test.dart (right):

https://codereview.chromium.org/11444018/diff/6005/utils/tests/pub/validator_...
utils/tests/pub/validator_test.dart:60: run();
I like this.

Expand Messages | Collapse Messages