Add a validator that checks package names.

utils/tests/pub/validator_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library validator_test;
 
 import 'dart:io';
 import 'dart:json';
 
 import 'test_pub.dart';
 import '../../../pkg/unittest/lib/unittest.dart';
 import '../../pub/entrypoint.dart';
 import '../../pub/io.dart';
 import '../../pub/validator.dart';
+import '../../pub/validator/name.dart';
 import '../../pub/validator/pubspec_field.dart';
 
 void expectNoValidationError(ValidatorCreator fn) {
   expectLater(schedulePackageValidation(fn), pairOf(isEmpty, isEmpty));
 }
 
 void expectValidationError(ValidatorCreator fn) {
   expectLater(schedulePackageValidation(fn), pairOf(isNot(isEmpty), anything));
 }
 
 void expectValidationWarning(ValidatorCreator fn) {
   expectLater(schedulePackageValidation(fn), pairOf(isEmpty, isNot(isEmpty)));
 }
 
 Validator pubspecField(Entrypoint entrypoint) =>
   new PubspecFieldValidator(entrypoint);
 
+Validator name(Entrypoint entrypoint) => new NameValidator(entrypoint);
+
 main() {
   group('should consider a package valid if it', () {
     test('looks normal', () {
       dir(appPath, [libPubspec("test_pkg", "1.0.0")]).scheduleCreate();
       expectNoValidationError(pubspecField);
       run();
     });
 
     test('has "authors" instead of "author"', () {
       var package = package("test_pkg", "1.0.0");
       package["authors"] = [package.remove("author")];
       dir(appPath, [pubspec(package)]).scheduleCreate();
       expectNoValidationError(pubspecField);
       run();
     });
+
+    test('has a badly-named library in lib/src', () {
+      dir(appPath, [
+        libPubspec("test_pkg", "1.0.0"),
+        dir("lib", [
+          file("test_pkg.dart", "int i = 1;"),
+          dir("src", [file("8ball.dart", "int j = 2;")])
+        ])
+      ]).scheduleCreate();
+      expectNoValidationError(name);
+      run();

[Bob Nystrom, 2012/12/07 17:07:43]

I like this.

+    });
   });
 
   group('should consider a package invalid if it', () {
     test('is missing the "homepage" field', () {
       var package = package("test_pkg", "1.0.0");
       package.remove("homepage");
       dir(appPath, [pubspec(package)]).scheduleCreate();
 
       expectValidationError(pubspecField);
       run();
@@ skipping 46 matching lines @@
       package["authors"] = [
         "Bob Nystrom <rnystrom@google.com>",
         "<nweiz@google.com>",
         "John Messerly <jmesserly@google.com>"
       ];
       dir(appPath, [pubspec(package)]).scheduleCreate();
 
       expectValidationWarning(pubspecField);
       run();
     });
+
+    test('has an empty package name', () {
+      dir(appPath, [libPubspec("", "1.0.0")]).scheduleCreate();
+      expectValidationError(name);
+      run();
+    });
+
+    test('has a package name with an invalid character', () {
+      dir(appPath, [libPubspec("test-pkg", "1.0.0")]).scheduleCreate();
+      expectValidationError(name);
+      run();
+    });
+
+    test('has a package name that begins with a number', () {
+      dir(appPath, [libPubspec("8ball", "1.0.0")]).scheduleCreate();
+      expectValidationError(name);
+      run();
+    });
+
+    test('has a package name that contains upper-case letters', () {
+      dir(appPath, [libPubspec("TestPkg", "1.0.0")]).scheduleCreate();
+      expectValidationWarning(name);
+      run();
+    });
+
+    test('has a package name that is a Dart identifier', () {
+      dir(appPath, [libPubspec("operator", "1.0.0")]).scheduleCreate();
+      expectValidationError(name);
+      run();
+    });
+
+    test('has a library name with an invalid character', () {
+      dir(appPath, [
+        libPubspec("test_pkg", "1.0.0"),
+        dir("lib", [file("test-pkg.dart", "int i = 0;")])
+      ]).scheduleCreate();
+      expectValidationError(name);
+      run();
+    });
+
+    test('has a library name that begins with a number', () {
+      dir(appPath, [
+        libPubspec("test_pkg", "1.0.0"),
+        dir("lib", [file("8ball.dart", "int i = 0;")])
+      ]).scheduleCreate();
+      expectValidationError(name);
+      run();
+    });
+
+    test('has a library name that contains upper-case letters', () {
+      dir(appPath, [
+        libPubspec("test_pkg", "1.0.0"),
+        dir("lib", [file("TestPkg.dart", "int i = 0;")])
+      ]).scheduleCreate();
+      expectValidationWarning(name);
+      run();
+    });
+
+    test('has a library name that is a Dart identifier', () {
+      dir(appPath, [
+        libPubspec("test_pkg", "1.0.0"),
+        dir("lib", [file("operator.dart", "int i = 0;")])
+      ]).scheduleCreate();
+      expectValidationError(name);
+      run();
+    });
   });
 }