Issue 11442024: Unify specification of file open, close, and write callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11442024: Unify specification of file open, close, and write callbacks. (Closed)

Created:
8 years ago by cshapiro

Modified:
8 years ago

Reviewers:
vsm, srdjan, siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Unify specification of file open, close, and write callbacks. Committed: https://code.google.com/p/dart/source/detail?r=15807

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -69 lines)			Patch
M	runtime/bin/gen_snapshot.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/bin/main.cc	View	4 chunks	+22 lines, -8 lines	0 comments	Download
M	runtime/bin/run_vm_tests.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/include/dart_api.h	View	4 chunks	+29 lines, -27 lines	0 comments	Download
M	runtime/vm/code_observers.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	runtime/vm/dart.h	View	3 chunks	+9 lines, -14 lines	0 comments	Download
M	runtime/vm/dart.cc	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	3 chunks	+9 lines, -5 lines	0 comments	Download
M	runtime/vm/heap.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/heap_profiler.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/heap_profiler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/isolate.h	View	2 chunks	+21 lines, -0 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

cshapiro

This change adds three arguments to the initialization api which requires coordination with dartium. Also, ...

8 years ago (2012-12-06 00:44:31 UTC) #1

Florian Schneider

On 2012/12/06 01:28:18, siva wrote: > LGTM > > I will let Srdjan comment on ...

8 years ago (2012-12-06 09:41:24 UTC) #3

lgtm