Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 11442024: Unify specification of file open, close, and write callbacks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/heap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index 5173713279a10c0ad1e983cba626480dca1f509b..39726f963c9c39455a80a2bf039056ccbe0f6b81 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -719,7 +719,7 @@ DART_EXPORT Dart_Handle Dart_RemoveGcEpilogueCallback(
}
-DART_EXPORT Dart_Handle Dart_HeapProfile(Dart_HeapProfileWriteCallback callback,
+DART_EXPORT Dart_Handle Dart_HeapProfile(Dart_FileWriteCallback callback,
void* stream) {
Isolate* isolate = Isolate::Current();
CHECK_ISOLATE(isolate);
@@ -740,8 +740,12 @@ DART_EXPORT bool Dart_Initialize(
Dart_IsolateCreateCallback create,
Dart_IsolateInterruptCallback interrupt,
Dart_IsolateUnhandledExceptionCallback unhandled,
- Dart_IsolateShutdownCallback shutdown) {
- const char* err_msg = Dart::InitOnce(create, interrupt, unhandled, shutdown);
+ Dart_IsolateShutdownCallback shutdown,
+ Dart_FileOpenCallback file_open,
+ Dart_FileWriteCallback file_write,
+ Dart_FileCloseCallback file_close) {
+ const char* err_msg = Dart::InitOnce(create, interrupt, unhandled, shutdown,
+ file_open, file_write, file_close);
if (err_msg != NULL) {
OS::PrintErr("Dart_Initialize: %s\n", err_msg);
return false;
@@ -4413,8 +4417,8 @@ DART_EXPORT void Dart_GetPprofSymbolInfo(void** buffer, int* buffer_size) {
}
-DART_EXPORT void Dart_InitPerfEventsSupport(Dart_FileWriterFunction function) {
- Dart::set_perf_events_writer(function);
+DART_EXPORT void Dart_InitPerfEventsSupport(void* perf_events_file) {
+ Dart::set_perf_events_file(perf_events_file);
}
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698