Issue 11438045: Make all allocation of external arrays used for IO use the IOBuffer class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11438045: Make all allocation of external arrays used for IO use the IOBuffer class (Closed)

Created:
8 years ago by Søren Gjesse

Modified:
8 years ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make all allocation of external arrays used for IO use the IOBuffer class This will not make a difference right now, but when we start to do something with io buffers they should originate from the same place. R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15785

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -34 lines)			Patch
M	runtime/bin/dartutils.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	2 chunks	+15 lines, -0 lines	0 comments	Download
M	runtime/bin/file.cc	View	3 chunks	+14 lines, -23 lines	0 comments	Download
M	runtime/bin/io_buffer.h	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/bin/io_buffer.cc	View	2 chunks	+7 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages