Issue 114353002: Implement work-around for "Placeholder for" error in JS output.

Issue 114353002: Implement work-around for "Placeholder for" error in JS output. (Closed)

Created:
7 years ago by floitsch

Modified:
7 years ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement work-around for "Placeholder for" error in JS output. BUG= http://dartbug.com/15602 R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=31109

Patch Set 2 : Address comments. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -4 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	tests/lib/mirrors/mirrors_used_get_name2_test.dart	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download
A	tests/lib/mirrors/mirrors_used_get_name_test.dart	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	tests/lib/mirrors/unused_mirrors_used_test.dart	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/114353002/diff/1/tests/lib/mirrors/mirrors_used_get_name2_test.dart File tests/lib/mirrors/mirrors_used_get_name2_test.dart (right): https://codereview.chromium.org/114353002/diff/1/tests/lib/mirrors/mirrors_used_get_name2_test.dart#newcode8 tests/lib/mirrors/mirrors_used_get_name2_test.dart:8: // "foo") to be preserved. Delete "the"? https://codereview.chromium.org/114353002/diff/1/tests/lib/mirrors/unused_mirrors_used_test.dart ...

7 years ago (2013-12-12 19:54:39 UTC) #2

floitsch

https://codereview.chromium.org/114353002/diff/1/tests/lib/mirrors/mirrors_used_get_name2_test.dart File tests/lib/mirrors/mirrors_used_get_name2_test.dart (right): https://codereview.chromium.org/114353002/diff/1/tests/lib/mirrors/mirrors_used_get_name2_test.dart#newcode8 tests/lib/mirrors/mirrors_used_get_name2_test.dart:8: // "foo") to be preserved. On 2013/12/12 19:54:40, ahe ...

7 years ago (2013-12-12 20:43:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r31109 (presubmit successful).

Expand Messages | Collapse Messages