Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2012)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart

Issue 114353002: Implement work-around for "Placeholder for" error in JS output. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/lib/lib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart b/sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart
index cae54917120d897cd7d221bde24e9cf2f99fc6fe..5dc01262237ae0aceb952d5e29e966b39fca63b9 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart
@@ -66,10 +66,10 @@ class TypeVariableHandler {
InterfaceType typeVariableType = typeVariableClass.computeType(compiler);
List<int> constants = <int>[];
evaluator = new CompileTimeConstantEvaluator(
- compiler.constantHandler,
- compiler.globalDependencies,
+ compiler.constantHandler,
+ compiler.globalDependencies,
compiler);
-
+
for (TypeVariableType currentTypeVariable in cls.typeVariables) {
List<Constant> createArguments(FunctionElement constructor) {
if (constructor != typeVariableConstructor) {
@@ -154,7 +154,8 @@ class TypeVariableHandler {
return typeVariableConstants[variable];
}
- emitter.globalMetadata.add('Placeholder for ${variable}');
+ // TODO(15613): Remove quotes.
+ emitter.globalMetadata.add('"Placeholder for ${variable}"');
return typeVariableConstants[variable] = emitter.globalMetadata.length - 1;
}
« no previous file with comments | « no previous file | tests/lib/lib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698