Always ignore non-public transformers.

Always ignore non-public transformers.

This was happening for the most part, but the dependency computer could
get tripped up when a package used a transformer from a dev dependency
on only private files.

R=rnystrom@google.com
BUG= http://dartbug.com/23480

Committed: https://github.com/dart-lang/sdk/commit/8298073cbca393dd0689aedef2770397bb2c9982

[Bob Nystrom, 2015-05-18 22:35:10]

https://codereview.chromium.org/1143453006/diff/1/sdk/lib/_internal/pub/test/...
File
sdk/lib/_internal/pub/test/transformer/ignores_a_transformer_on_test_files_in_a_dependency_test.dart
(right):

https://codereview.chromium.org/1143453006/diff/1/sdk/lib/_internal/pub/test/...
sdk/lib/_internal/pub/test/transformer/ignores_a_transformer_on_test_files_in_a_dependency_test.dart:31:
}]
It might help to actually have a test asset just to ensure the test is passing
because the test assets are not considered not just because there happen to not
be any.

https://codereview.chromium.org/1143453006/diff/1/sdk/lib/_internal/pub/test/...
sdk/lib/_internal/pub/test/transformer/ignores_a_transformer_on_test_files_in_a_dependency_test.dart:49:
endPubServe();
This could still pass even if the test files were being transformed, couldn't
it? Maybe have the transformer log output or fail so we can ensure it doesn't
run?

[nweiz, 2015-05-19 00:39:58]

Code review changes

[nweiz, 2015-05-19 00:40:06]

https://codereview.chromium.org/1143453006/diff/1/sdk/lib/_internal/pub/test/...
File
sdk/lib/_internal/pub/test/transformer/ignores_a_transformer_on_test_files_in_a_dependency_test.dart
(right):

https://codereview.chromium.org/1143453006/diff/1/sdk/lib/_internal/pub/test/...
sdk/lib/_internal/pub/test/transformer/ignores_a_transformer_on_test_files_in_a_dependency_test.dart:31:
}]
On 2015/05/18 22:35:10, Bob Nystrom wrote:
> It might help to actually have a test asset just to ensure the test is passing
> because the test assets are not considered not just because there happen to
not
> be any.

Done.

https://codereview.chromium.org/1143453006/diff/1/sdk/lib/_internal/pub/test/...
sdk/lib/_internal/pub/test/transformer/ignores_a_transformer_on_test_files_in_a_dependency_test.dart:49:
endPubServe();
On 2015/05/18 22:35:10, Bob Nystrom wrote:
> This could still pass even if the test files were being transformed, couldn't
> it? Maybe have the transformer log output or fail so we can ensure it doesn't
> run?

In theory the dev dependency logic should make it fail to load, but I'll make it
invalid Dart code too, just in case.

[Bob Nystrom, 2015-05-20 23:34:23]

LGTM!

[nweiz, 2015-05-21 00:44:51]

Committed patchset #2 (id:20001) manually as
8298073cbca393dd0689aedef2770397bb2c9982 (presubmit successful).