Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/dependency_computer.dart

Issue 1143453006: Always ignore non-public transformers. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Code review changes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/pub/test/transformer/ignores_a_transformer_on_test_files_in_a_dependency_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/barback/dependency_computer.dart
diff --git a/sdk/lib/_internal/pub/lib/src/barback/dependency_computer.dart b/sdk/lib/_internal/pub/lib/src/barback/dependency_computer.dart
index 9e46b46d06b15d1f3d0cff2ac6801abdb6af3dea..facf14084a28056e6d900ebaee570abb05a1bbc2 100644
--- a/sdk/lib/_internal/pub/lib/src/barback/dependency_computer.dart
+++ b/sdk/lib/_internal/pub/lib/src/barback/dependency_computer.dart
@@ -254,6 +254,9 @@ class _PackageDependencyComputer {
String packageName)
: _dependencyComputer = dependencyComputer,
_package = dependencyComputer._graph.packages[packageName] {
+ var isRootPackage =
+ packageName == _dependencyComputer._graph.entrypoint.root.name;
+
// If [_package] uses its own transformers, there will be fewer transformers
// running on [_package] while its own transformers are loading than there
// will be once all its transformers are finished loading. To handle this,
@@ -262,6 +265,9 @@ class _PackageDependencyComputer {
// smaller.
for (var phase in _package.pubspec.transformers) {
for (var config in phase) {
+ // Ignore non-root transformers on non-public files.
+ if (!isRootPackage && !config.canTransformPublicFiles) continue;
+
var id = config.id;
try {
if (id.package != _package.name) {
« no previous file with comments | « no previous file | sdk/lib/_internal/pub/test/transformer/ignores_a_transformer_on_test_files_in_a_dependency_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698