Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1142933003: Ensure ErroneousElement for static getter with no setter. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure ErroneousElement for static getter with no setter. BUG= R=herhut@google.com Committed: https://github.com/dart-lang/sdk/commit/c4d65452e0566986a48f4bfb57076192ce083860

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -4 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +6 lines, -4 lines 0 comments Download
A tests/language/static_getter_no_setter1_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A tests/language/static_getter_no_setter2_test.dart View 1 chunk +33 lines, -0 lines 0 comments Download
A tests/language/static_getter_no_setter3_test.dart View 1 chunk +27 lines, -0 lines 2 comments Download
A tests/language/top_level_getter_no_setter1_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A tests/language/top_level_getter_no_setter2_test.dart View 1 chunk +28 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 7 months ago (2015-05-19 12:44:12 UTC) #2
herhut
lgtm w/ comments https://codereview.chromium.org/1142933003/diff/1/tests/language/static_getter_no_setter3_test.dart File tests/language/static_getter_no_setter3_test.dart (right): https://codereview.chromium.org/1142933003/diff/1/tests/language/static_getter_no_setter3_test.dart#newcode11 tests/language/static_getter_no_setter3_test.dart:11: getter_visited = true; I am not ...
5 years, 7 months ago (2015-05-19 14:18:31 UTC) #3
Johnni Winther
https://codereview.chromium.org/1142933003/diff/1/tests/language/static_getter_no_setter3_test.dart File tests/language/static_getter_no_setter3_test.dart (right): https://codereview.chromium.org/1142933003/diff/1/tests/language/static_getter_no_setter3_test.dart#newcode11 tests/language/static_getter_no_setter3_test.dart:11: getter_visited = true; On 2015/05/19 14:18:31, herhut wrote: > ...
5 years, 7 months ago (2015-05-20 07:49:42 UTC) #4
Johnni Winther
5 years, 7 months ago (2015-05-20 07:55:28 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c4d65452e0566986a48f4bfb57076192ce083860 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698