Issue 11421220: Fix test scripts to work with an absolute build directory path on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11421220: Fix test scripts to work with an absolute build directory path on Windows. (Closed)

Created:
8 years ago by Bill Hesse

Modified:
8 years ago

Reviewers:
Anton Muhin, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix test scripts to work with an absolute build directory path on Windows. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15683

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	tools/testing/dart/test_suite.dart	View		2 chunks	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years ago (2012-12-04 11:24:51 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/11421220/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11421220/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:801: String htmlPath = '$tempDir/test.html';
I'm getting a feeling that this should have been an instance of Uri.  What do
you think?

Expand Messages | Collapse Messages