Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11421220: Fix test scripts to work with an absolute build directory path on Windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 0f3f009c71fe297230e6d8de3a30daae3ebece1b..d99ba3b87e42dbad34946fb593e88ad3954082a6 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -527,7 +527,7 @@ class StandardTestSuite extends TestSuite {
Directory dir = new Directory.fromPath(suiteDir);
return dir.exists().chain((exists) {
if (!exists) {
- print('Directory containing tests not found: $suiteDir');
+ print('Directory containing tests missing: ${suiteDir.toNativePath()}');
return new Future.immediate(null);
} else {
var group = new FutureGroup();
@@ -896,7 +896,9 @@ class StandardTestSuite extends TestSuite {
do {
List<String> args = <String>[];
String fullHtmlPath = htmlPath.startsWith('http:') ? htmlPath :
- 'file://$htmlPath';
+ (htmlPath.startsWith('/') ?
+ 'file://$htmlPath' :
+ 'file:///$htmlPath');
if (info.optionsFromFile['isMultiHtmlTest']
&& subtestNames.length > 0) {
fullHtmlPath = '${fullHtmlPath}#${subtestNames[subtestIndex]}';
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698