Issue 11418004: Don't copy Int8Arrays when passing them in as lists of bytes and don't

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11418004: Don't copy Int8Arrays when passing them in as lists of bytes and don't (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)

Modified:
8 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't copy Int8Arrays when passing them in as lists of bytes and don't call from C to Dart to get the values either. Just copying the values over as is will behave the same as it does now and will be a lot faster. R=sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14951

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	runtime/vm/dart_api_impl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	sdk/lib/io/common.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

STV!

Expand Messages | Collapse Messages